Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python_models test reformat #337

Merged
merged 10 commits into from
Dec 5, 2022
Merged

Python_models test reformat #337

merged 10 commits into from
Dec 5, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Dec 2, 2022

resolves #305

Description

changing python_model test configs to take into account swap for anonymous_sproc as new default

Checklist

@McKnight-42 McKnight-42 self-assigned this Dec 2, 2022
@cla-bot cla-bot bot added the cla:yes label Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

dbt.config(
materialized='table',
imports = ['@dbt_integration_test/iris.csv'],
use_anonymous_sproc = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe modify this to be false so the we have one test testing the other path

Copy link
Contributor Author

@McKnight-42 McKnight-42 Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was wanting to double check with you on that, if we had a specific one we preferred flipping or if we just wanted to add another test like the initial one that swaps there. will make change and we can see how it all shakes out.

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@McKnight-42 McKnight-42 merged commit df24397 into main Dec 5, 2022
@McKnight-42 McKnight-42 deleted the mcknight/ct-1458 branch December 5, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1458] [Feature] change default dbt-py method to anonymous stored procedures (sprocs)
2 participants