Skip to content

Commit

Permalink
Fixes CI to depend on the release branch for Core (#128)
Browse files Browse the repository at this point in the history
* Remove unneeded Core download in CI (#127)

* Update dev_requirements for 1.0.latest branch

* Use new agate_helper.Number type in tests for table creation (#76)

* Use new agate_helper.Number type for table creation

* Revert "Use new agate_helper.Number type for table creation"

This reverts commit 4d72ac7.

* Update test of Number type check from Boolean to 0,1

Co-authored-by: Anton Huck <anthu@users.noreply.github.com>
  • Loading branch information
leahwicz and anthu authored Apr 1, 2022
1 parent f1ade11 commit 43d4f03
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 10 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,6 @@ jobs:
pip --version
tox --version
- name: Install dbt-core latest
run: |
pip install "git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core"
- name: Run tox (snowflake)
if: matrix.adapter == 'snowflake'
env:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ jobs:
pip install --upgrade setuptools wheel twine check-wheel-contents
pip --version
- name: Install dbt-core latest
run: |
pip install "git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core"
- name: Build distributions
run: ./scripts/build-dist.sh

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

### Under the hood
- Resolves an issue caused when the Snowflake OCSP server is not accessible, by exposing the `insecure_mode` boolean avalable in the Snowflake python connector ([#31](https://github.com/dbt-labs/dbt-snowflake/issues/31), [#49](https://github.com/dbt-labs/dbt-snowflake/pull/49))
- Fix test related to preventing coercion of boolean values (True, False) to numeric values (0, 1) in query results ([#76](https://github.com/dbt-labs/dbt-snowflake/issues/76))

### Contributors
- [@anthu](https://github.com/anthu) ([#48](https://github.com/dbt-labs/dbt-snowflake/pull/48))
Expand Down
2 changes: 1 addition & 1 deletion dev_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt.git@1.0.latest#egg=dbt-core&subdirectory=core

bumpversion
flake8
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def _get_tester_for(self, column_type):
return agate.TimeDelta()

for instance in agate_helper.DEFAULT_TYPE_TESTER._possible_types:
if type(instance) is column_type:
if isinstance(instance, column_type): # include child types
return instance

raise ValueError(f'no tester for {column_type}')
Expand Down

0 comments on commit 43d4f03

Please sign in to comment.