Add Defaults for SemanticModel #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d73a82 to
fa21754
Compare
tlento
approved these changes
May 30, 2023
| @@ -18,7 +18,7 @@ | |||
|
|
|||
|
|
|||
| class SetMeasureAggregationTimeDimensionRule(ProtocolHint[SemanticManifestTransformRule[PydanticSemanticManifest]]): | |||
| """Sets the aggregation time dimension for measures to the primary time dimension if not defined.""" | |||
| """Sets the aggregation time dimension for measures to the done specified as default.""" | |||
Comment on lines
-42
to
-67
| primary_time_dimensions = [] | ||
|
|
||
| for dim in semantic_model.dimensions: | ||
| if dim.type == DimensionType.TIME and dim.type_params is not None and dim.type_params.is_primary: | ||
| primary_time_dimensions.append(dim) | ||
|
|
||
| # A semantic model must have a primary time dimension if it has | ||
| # any measures that don't have an `agg_time_dimension` set | ||
| if ( | ||
| len(primary_time_dimensions) == 0 | ||
| and len(semantic_model.measures) > 0 | ||
| and any(measure.agg_time_dimension is None for measure in semantic_model.measures) | ||
| ): | ||
| issues.append( | ||
| ValidationError( | ||
| context=SemanticModelContext( | ||
| file_context=FileContext.from_metadata(metadata=semantic_model.metadata), | ||
| semantic_model=SemanticModelReference(semantic_model_name=semantic_model.name), | ||
| ), | ||
| message=f"No primary time dimension in semantic model with name ({semantic_model.name}). " | ||
| "Please add one", | ||
| ) | ||
| ) | ||
|
|
||
| if len(primary_time_dimensions) > 1: | ||
| for primary_time_dimension in primary_time_dimensions: |
There was a problem hiding this comment.
Oh this is so much better without all of this stuff....
| @@ -124,60 +111,3 @@ def test_incompatible_dimension_is_partition() -> None: # noqa:D | |||
| ], | |||
| ) | |||
| ) | |||
|
|
|||
|
|
|||
| def test_multiple_primary_time_dimensions() -> None: # noqa:D | |||
| if ( | ||
| dimension.type_params is not None | ||
| and not dimension.type_params.is_primary |
There was a problem hiding this comment.
Oh huh. This is vestigial from the time before metric_time, right?
fa21754 to
d4c32e2
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves # 50
Description
This PR adds a
defaultssection in theSemanticModeldefinition that can be used to specify default values for objects listed in the model. e.g.In addition, this removes
Dimension.is_primarysince it's no longer needed with the introduction ofmetric_timeanddefaults.agg_time_dimensions.Checklist
changie newto create a changelog entry