Improve validations for derived metrics #279
Merged
+86
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serramatutu
approved these changes
May 24, 2024
WilliamDee
approved these changes
May 24, 2024
courtneyholcomb
added a commit
that referenced
this pull request
Jun 5, 2024
This reverts commit 4127671.
courtneyholcomb
added a commit
that referenced
this pull request
Jun 5, 2024
Reverts #279 With the onset of dbt-mantle, we can no longer add new validations that might cause errors for existing manifests, or customers might see jobs abruptly failing. Instead, we need to figure out a new process for rolling out validations - likely adding warnings to start.
courtneyholcomb
added a commit
that referenced
this pull request
Jun 16, 2024
Improve validations for derived metrics. - If there were no input metrics set, previously users would run into an `AssertionError` that interrupts the semantic manifest validation process. This changes that to be a more user-friendly validation error. - Add a validation to ensure that `expr` is set and that it references all the input metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #270
Description
Improve validations for derived metrics.
AssertionErrorthat interrupts the semantic manifest validation process. This changes that to be a more user-friendly validation error.expris set and that it references all the input metrics.Checklist
changie newto create a changelog entry