Add Primary Entity Prefix When Specifying Dimensions in the WhereFilter #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1dc2eb0 to
90fece9
Compare
QMalcolm
approved these changes
Jul 28, 2023
| dimension_reference=DimensionReference(element_name=group_by_item_name.element_name), | ||
| entity_path=( | ||
| tuple(EntityReference(element_name=arg) for arg in entity_path) | ||
| + group_by_item_name.entity_links |
There was a problem hiding this comment.
So the primary entity will be the last one in the entity_path tuple. Cool Cool 👍
87b3fd4 to
49e1388
Compare
tlento
reviewed
Jul 28, 2023
Comment on lines
+19
to
+21
| e.g. listing__ds__week -> | ||
| entity_links: ["listing"] | ||
| element_name: "ds" | ||
| granularity: TimeGranularity.WEEK |
There was a problem hiding this comment.
Can we indicate that including time granularity is a legacy anti-pattern and no implementer should be relying on it? It has caused so much trouble, and we are trying to eliminate it somehow or other.
90fece9 to
7351937
Compare
4aa22a6 to
df0645b
Compare
With the invariant that all dimensions are associated with a primary entity,
require the specification of the entity when using dimensions in the where
filter.
e.g.
```
dimension('capacity_latest') > 10
->
dimension('listing__capacity_latest') > 10
```
df0645b to
f322968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123
Description
With the invariant that all dimensions are associated with a primary entity, require the specification of the entity when using dimensions in the where filter.
e.g.
Checklist
changie newto create a changelog entry