Add Redshift internal build process workflow #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VersusFacit
commented
Mar 18, 2024
This was referenced Mar 18, 2024
emmyoop
requested changes
Mar 18, 2024
| invoke-reusable-workflow: | ||
| name: Build and Release Internally | ||
|
|
||
| uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main |
There was a problem hiding this comment.
Just noting this needs to be updated once the dbt-release PR gets merged.
Suggested change
| uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main | |
| uses: dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@main |
| @@ -50,7 +61,7 @@ def _plugin_version() -> str: | |||
| install_requires=[ | |||
| "dbt-common>=0.1.0a1,<2.0", | |||
| "dbt-adapters>=0.1.0a1,<2.0", | |||
| f"dbt-postgres~={_plugin_version()}", | |||
| f"dbt-postgres~={_plugin_version_trim()}", | |||
There was a problem hiding this comment.
@mikealfare can this be done without ~=?
There was a problem hiding this comment.
I would need to look at it, but I would think so. We would need to update the function to return a tuple, something along the lines of "dbt-postgres>={},<{}".format(_plugin_version()) where _plugin_version() == (1.8.0b1, 1.9).
emmyoop
approved these changes
Mar 19, 2024
|
Tests are failing here due to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #38 in epic
Problem
We need a workflow to release things internally
Solution
Write the workflow. I'll be opening up a PR for the workflow this one calls.
Followup actions including reconfiguring secrets and doing a full run start to finish!
Checklist