Add tests on incremental materialization #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and reopening to trigger integration test, now that |
jtcohen6
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Looks great @Kayrnt, just one comment.
Sorry the integration test is a bit more involved over in these plugins. We refactored the code for test_incremental_schema.py over in dbt-core, to keep it more narrowly focused, but that was after the adapter split-apart was complete.
There are some unrelated integration test failures (#36), we can ignore those for the purposes of this PR
| @@ -91,6 +91,21 @@ def run_incremental_append_new_columns(self): | |||
| self.list_tests_and_assert(select, exclude, expected) | |||
| self.run_tests_and_assert(select, exclude, expected, compare_source, compare_target) | |||
|
|
|||
| def run_incremental_append_new_columns_remove_one(self): | |||
There was a problem hiding this comment.
This just needs to be added down below as well:
@use_profile('redshift')
def test__redshift__run_incremental_append_new_columns(self):
self.run_incremental_append_new_columns()
self.run_incremental_append_new_columns_remove_one()
5056746 to
9ed3474
Compare
jtcohen6
approved these changes
Nov 8, 2021
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#4144
Description
Following dbt-labs/dbt-core#4170, it makes sense to add a dedicated tests to avoid regression on that change for Redshift integration.
I didn't edited the changelog as it only affects the tests.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-redshift next" section.