Fix tests for dbt-labs/dbt-core#3955 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2021
leahwicz
approved these changes
Oct 27, 2021
|
I just was about to say the same thing lol! I saw they failed when I woke up. Yes we need a better alerting system for sure and somehow not need to change this code all over the place |
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
* Fix tests for dbt-labs/dbt-core#3955 * Methods renamed in dbt-labs/dbt-core#4101 * Missed one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need:
dbt-corechanges. This is especially true oftest_docs_generate.pyChecklist
I have run this code in development and it appears to resolve the stated issueThis PR includes tests, or tests are not required/relevant for this PRI have updated theCHANGELOG.mdand added information about my change to the "dbt-redshift next" section.