update release workflow to support macos arm64 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed here that we are only building arm64 for python 3.6 which is odd. |
4 tasks
|
Confirmed arm64 compat wheels are being generated for py3.6-py3.9 https://github.com/dbt-labs/dbt-extractor/runs/4411916006?check_suite_focus=true#step:7:8 |
1 task
jtcohen6
approved these changes
Dec 6, 2021
e51f549 to
fcf19ab
Compare
fcf19ab to
411b789
Compare
|
This is ready to go! you can see a list of distributions this workflow creates here https://github.com/dbt-labs/dbt-extractor/runs/4434445906?check_suite_focus=true#step:3:1 |
nathaniel-may
approved these changes
Dec 6, 2021
| name: Build linux ${{ matrix.target }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: |
There was a problem hiding this comment.
why don't we need python version here?
There was a problem hiding this comment.
When setting this argument
The
messense/maturin-action@v1 action builds wheels in a docker container and uses the python versions that are available in the docker container, not the interpreters installed in the VM by GHA. You can see what python versions are supported here https://github.com/messense/maturin-action/blob/51478586be5dfb16a569cb6bbec182fba9f13f79/src/index.ts#L245
I'll add a comment to the source code calling this out!
added 2 commits
December 6, 2021 13:56
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #32 and dbt-labs/dbt-core#4185
Note: We can kick off a release for 0.4.0 again, it will publish the missing wheels.