Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for better version support #411

Merged
merged 4 commits into from
Apr 11, 2023
Merged

update for better version support #411

merged 4 commits into from
Apr 11, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 11, 2023

resolves #406

Description

Adds some support for versions.

Add version to the details page
Screen Shot 2023-04-11 at 2 11 47 PM

add version to model name on DAG
image

Add version to model name in Project
image

Search is also updated
Screen Shot 2023-04-11 at 2 22 11 PM

Known issue: all versions of a selected versioned model get selected when viewing in the collapsed version. When you expand it, it works correctly.
image

Checklist

@cla-bot cla-bot bot added the cla:yes label Apr 11, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop force-pushed the er/ct-2328-versions branch from fc2a6b9 to afe7da6 Compare April 11, 2023 19:21
@jtcohen6
Copy link
Contributor

I attempted (56ad654) to add some logic to getNodesByFQN such that all of the following will select a versioned model:

  • dim_customers (all versions of dim_customers)
  • v2 (all models with v2)
  • dim_customers.v2 (with dot)
  • dim_customers_v2 (with underscore)

@emmyoop emmyoop merged commit 520d0a9 into main Apr 11, 2023
@emmyoop emmyoop deleted the er/ct-2328-versions branch April 11, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2328] [Spike] Display versioned models in dbt-docs
3 participants