Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection by group to DAG #392

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Add selection by group to DAG #392

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d54e48
first pass at adding group selector
emmyoop Mar 8, 2023
3d02886
add group selector
emmyoop Mar 8, 2023
2191312
changelog
emmyoop Mar 8, 2023
9ae85e5
Update src/app/services/selector_matcher.js
emmyoop Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Docs-20230308-093736.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Docs
body: Add selection by group to DAG
time: 2023-03-08T09:37:36.78968-06:00
custom:
Author: emmyoop
Issue: "380"
16 changes: 16 additions & 0 deletions src/app/services/selector_matcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ var SELECTOR_TYPE = {
SOURCE: 'source',
EXPOSURE: 'exposure',
METRIC: 'metric',
GROUP: 'group',
PATH: 'path',
FILE: 'file',
PACKAGE: 'package',
Expand All @@ -24,6 +25,7 @@ NODE_MATCHERS[SELECTOR_TYPE.TAG] = getNodesByTag;
NODE_MATCHERS[SELECTOR_TYPE.SOURCE] = getNodesBySource;
NODE_MATCHERS[SELECTOR_TYPE.EXPOSURE] = getNodesByExposure;
NODE_MATCHERS[SELECTOR_TYPE.METRIC] = getNodesByMetric;
NODE_MATCHERS[SELECTOR_TYPE.GROUP] = getNodesByGroup;
NODE_MATCHERS[SELECTOR_TYPE.PATH] = getNodesByPath;
NODE_MATCHERS[SELECTOR_TYPE.FILE] = getNodesByFile;
NODE_MATCHERS[SELECTOR_TYPE.PACKAGE] = getNodesByPackage;
Expand Down Expand Up @@ -300,6 +302,20 @@ function getNodesByMetric(elements, metric) {
return nodes;
}

function getNodesByGroup(elements, group) {
var nodes = [];
_.each(elements, function(node_obj) {
var node = node_obj.data;

if (node.group == group) {
nodes.push(node);
}
});
return nodes;

emmyoop marked this conversation as resolved.
Show resolved Hide resolved

}
emmyoop marked this conversation as resolved.
Show resolved Hide resolved

function getNodesFromSpec(dag, pristine_nodes, maxHops, selector) {
const matcher = NODE_MATCHERS[selector.selector_type];
if (!matcher) {
Expand Down