Simplify core release inputs #9429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9429 +/- ##
==========================================
+ Coverage 86.96% 87.90% +0.93%
==========================================
Files 187 150 -37
Lines 25014 21915 -3099
==========================================
- Hits 21754 19264 -2490
+ Misses 3260 2651 -609
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Codecov is failing but I don't know why since all I changed were workflows. It doesn't block merging. |
martynydbt
reviewed
Jan 23, 2024
.github/workflows/release.yml
Outdated
|
|
||
| # release-prep.yml really shouldn't take in the sha but since core + all adapters | ||
| # depend on it now this workaround lets us not input it manually with risk of error. | ||
| # The changes always get merged into the head so we can't use a specific commit fo |
martynydbt
approved these changes
Jan 23, 2024
emmyoop
commented
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9431
relates to dbt-labs/dbt-release#69
Problem
Release inputs are long and not all of them are really necessary or add value to being flexible.
Solution
Simplify inputs to only what's needed
Nightly tests are also updated to reflect these changes.
Test run: https://github.com/dbt-labs/dbt-core/actions/runs/7630615252
Checklist