Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make relation Filtering None-tolerant for maximal flexibility #8975

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

peterallenwebb
Copy link
Contributor

resolves #8974

Problem

Spark needs flexibility to have None/null value for the database identifier.

Solution

We now explicitly allow that.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb21403) 86.46% compared to head (baf83a2) 86.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8975      +/-   ##
==========================================
+ Coverage   86.46%   86.51%   +0.05%     
==========================================
  Files         179      179              
  Lines       26505    26508       +3     
==========================================
+ Hits        22917    22933      +16     
+ Misses       3588     3575      -13     
Flag Coverage Δ
integration 83.40% <100.00%> (+0.12%) ⬆️
unit 64.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/adapters/base/impl.py 82.93% <100.00%> (+0.07%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3306] [Bug] Spark Integration Failure Due in get_filtered_catalog()
2 participants