Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc string context to Identifier validion regex rule #8440

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

QMalcolm
Copy link
Contributor

Problem

The regex pattern for Identifier string validation had no context on WHY the restriction of identifiers was
what it was.

Solution

Add a docstring documenting the reason for the regex.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Aug 17, 2023
@QMalcolm QMalcolm requested a review from a team as a code owner August 17, 2023 16:01
@cla-bot cla-bot bot added the cla:yes label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #8440 (806af2e) into main (ac539fd) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8440   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files         174      174           
  Lines       25561    25561           
=======================================
  Hits        22062    22062           
  Misses       3499     3499           
Flag Coverage Δ
integration 83.09% <ø> (ø)
unit 65.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/contracts/util.py 92.36% <ø> (ø)

@QMalcolm QMalcolm merged commit d088d44 into main Aug 17, 2023
@QMalcolm QMalcolm deleted the qmalcolm--identifier-validation-context-comment branch August 17, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants