Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix constructing param with 0 value #8298

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix constructing param with 0 value #8298

merged 2 commits into from
Aug 2, 2023

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Aug 2, 2023

resolves #8297
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner August 2, 2023 21:17
@ChenyuLInx ChenyuLInx requested a review from QMalcolm August 2, 2023 21:17
@cla-bot cla-bot bot added the cla:yes label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #8298 (fd57e2a) into main (a433c31) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8298   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         174      174           
  Lines       25518    25518           
=======================================
  Hits        22017    22017           
  Misses       3501     3501           
Files Changed Coverage Δ
core/dbt/cli/flags.py 92.10% <100.00%> (ø)

core/dbt/cli/flags.py Outdated Show resolved Hide resolved
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing additional to add, looks good to me

@ChenyuLInx ChenyuLInx merged commit 1af489b into main Aug 2, 2023
@ChenyuLInx ChenyuLInx deleted the cl/parse_command branch August 2, 2023 21:57
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
* fix constructing param with 0 value

* Update core/dbt/cli/flags.py

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

---------

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
(cherry picked from commit 1af489b)
ChenyuLInx added a commit that referenced this pull request Aug 14, 2023
* fix constructing param with 0 value

* Update core/dbt/cli/flags.py

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

---------

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
(cherry picked from commit 1af489b)

Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2924] [Bug] Retry does not construct flags properly for 0 valued parameter
3 participants