Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue One Event Per Node Failure #8210

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

peterallenwebb
Copy link
Contributor

resolves #7963

Problem

Previous versions of dbt fired one event for each line in a node error message. This didn't make a lot of sense, and although it didn't affect console output, it meant that the JSON log had a separate full JSON object for each line in the error message.

Solution

We now fire a single event containing the entire message, which may still contain line breaks internally.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #8210 (d72ec60) into main (6130a6e) will decrease coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #8210      +/-   ##
==========================================
- Coverage   86.26%   86.23%   -0.04%     
==========================================
  Files         174      174              
  Lines       25517    25518       +1     
==========================================
- Hits        22013    22006       -7     
- Misses       3504     3512       +8     
Files Changed Coverage Δ
core/dbt/events/types.py 98.62% <ø> (-0.02%) ⬇️
core/dbt/events/eventmgr.py 88.67% <81.25%> (-0.98%) ⬇️
core/dbt/events/functions.py 92.79% <100.00%> (+0.13%) ⬆️
core/dbt/task/printer.py 97.46% <100.00%> (-0.16%) ⬇️

... and 1 file with indirect coverage changes

@peterallenwebb peterallenwebb marked this pull request as ready for review August 1, 2023 22:46
@peterallenwebb peterallenwebb requested a review from a team as a code owner August 1, 2023 22:46
@peterallenwebb peterallenwebb requested a review from aranke August 1, 2023 22:46
@peterallenwebb peterallenwebb merged commit 5814928 into main Aug 2, 2023
@peterallenwebb peterallenwebb deleted the paw/single-line-result-message branch August 2, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2748] [Feature] A single Structured Logging JSON dictionary per Exception
2 participants