Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #7586, Remove unused check_new method #7756

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

kevinneville
Copy link
Contributor

resolves #7586

Description

Remove unused check_new method.

Checklist

@kevinneville kevinneville requested review from a team as code owners June 1, 2023 18:44
@kevinneville kevinneville requested review from emmyoop and VersusFacit and removed request for a team June 1, 2023 18:44
@cla-bot cla-bot bot added the cla:yes label Jun 1, 2023
@kevinneville
Copy link
Contributor Author

Forgot to run black locally. Should be fixed now.

@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jun 25, 2023
@gshank gshank closed this Jun 28, 2023
@gshank gshank reopened this Jun 28, 2023
@gshank
Copy link
Contributor

gshank commented Jun 28, 2023

Tests aren't passing. Maybe try merging main?

@gshank gshank closed this Sep 15, 2023
@gshank gshank reopened this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@7a06d35). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7756   +/-   ##
=======================================
  Coverage        ?   86.60%           
=======================================
  Files           ?      175           
  Lines           ?    25636           
  Branches        ?        0           
=======================================
  Hits            ?    22203           
  Misses          ?     3433           
  Partials        ?        0           
Flag Coverage Δ
integration 83.45% <ø> (?)
unit 65.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop removed their request for review October 5, 2023 13:26
Copy link

@ariosramirez ariosramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbeatty10 dbeatty10 added the community This PR is from a community member label Apr 3, 2024
@gshank gshank merged commit 994a089 into dbt-labs:main May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2559] [Feature] Remove unused check_new method
5 participants