CT 1993 handle invalid access to private models #7069
Conversation
core/dbt/parser/manifest.py
Outdated
| target_model.resource_type == NodeType.Model | ||
| and target_model.access == AccessType.Private | ||
| ): | ||
| # Metrics do not have a group and so can never reference private models |
There was a problem hiding this comment.
I believe metrics should actually be groupable as per #6823 and the implementation in #6965. Exposures should not be groupable though (#6826). cc @jtcohen6 to confirm 🙏
There was a problem hiding this comment.
There is no "group" field on a Metric node, but I see that there is on MetricConfig, so if it were set in config on a metric it would blow up in "update_parsed_node_config". Should I add a "group" field on Metric?
There was a problem hiding this comment.
It looks like group doesn't work at all for metrics.
There was a problem hiding this comment.
Actually metrics doesn't even use update_parsed_node_config, so it wouldn't have blown up, but there wasn't a "group" field on metric. I added the group field and copied it from config to node level. I used the node level field in 'process_refs..." calls. If we're going to copy that field to node level we should probably use that consistently. Or not bother with the copying.
core/dbt/exceptions.py
Outdated
| def get_message(self) -> str: | ||
| return ( | ||
| f"Node {self.unique_id} attempted to reference node {self.ref_unique_id}, " | ||
| "which is not allowed because the referenced node is private to the {self.group} group." |
There was a problem hiding this comment.
Error message looks good, but this is missing the f-string + initializion self.group
There was a problem hiding this comment.
It's just so very Monday today.
90c6129 to
946fa01
Compare
resolves #6826
Description
Throw a DbtReferenceError if a private model is accessed from a non-group model, or from an exposure or metric.
Checklist
changie newto create a changelog entry