Fix regression in semver comparison logic #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
approved these changes
Feb 23, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
(cherry picked from commit 915585c)
nssalian
pushed a commit
that referenced
this pull request
Feb 24, 2023
gshank
pushed a commit
that referenced
this pull request
Sep 8, 2024
gshank
added a commit
that referenced
this pull request
Sep 9, 2024
* CT 2000 fix semver prerelease comparisons (#6838) (#6958) * Modify semver.py to not use packaging.version.parse * Changie (cherry picked from commit d9424cc) Co-authored-by: Gerda Shank <gerda@dbtlabs.com> * Fix regression in semver comparison logic (#7040) (#7041) (cherry picked from commit 915585c) Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Fix changed name of exception --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
* CT 2000 fix semver prerelease comparisons (#6838) (#6958) * Modify semver.py to not use packaging.version.parse * Changie (cherry picked from commit d9424cc) Co-authored-by: Gerda Shank <gerda@dbtlabs.com> * Fix regression in semver comparison logic (#7040) (#7041) (cherry picked from commit 915585c) Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Fix changed name of exception --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> (cherry picked from commit 9e85a22)
gshank
added a commit
that referenced
this pull request
Sep 9, 2024
* CT 2000 fix semver prerelease comparisons (#6838) (#6958) * Modify semver.py to not use packaging.version.parse * Changie (cherry picked from commit d9424cc) Co-authored-by: Gerda Shank <gerda@dbtlabs.com> * Fix regression in semver comparison logic (#7040) (#7041) (cherry picked from commit 915585c) Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Fix changed name of exception --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
gshank
added a commit
that referenced
this pull request
Sep 9, 2024
* CT 2000 fix semver prerelease comparisons (#6838) (#6958) * Modify semver.py to not use packaging.version.parse * Changie (cherry picked from commit d9424cc) Co-authored-by: Gerda Shank <gerda@dbtlabs.com> * Fix regression in semver comparison logic (#7040) (#7041) (cherry picked from commit 915585c) Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Fix changed name of exception --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
gshank
added a commit
that referenced
this pull request
Sep 10, 2024
* CT 2000 fix semver prerelease comparisons (#6838) (#6958) * Modify semver.py to not use packaging.version.parse * Changie (cherry picked from commit d9424cc) Co-authored-by: Gerda Shank <gerda@dbtlabs.com> * Fix regression in semver comparison logic (#7040) (#7041) (cherry picked from commit 915585c) Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Fix changed name of exception --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> (cherry picked from commit 9e85a22) Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
gshank
added a commit
that referenced
this pull request
Sep 10, 2024
* CT 2000 fix semver prerelease comparisons (#6838) (#6958) * Modify semver.py to not use packaging.version.parse * Changie (cherry picked from commit d9424cc) * Fix regression in semver comparison logic (#7040) (#7041) (cherry picked from commit 915585c) * Fix changed name of exception --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
gshank
added a commit
that referenced
this pull request
Sep 10, 2024
* CT 2000 fix semver prerelease comparisons (#6838) (#6958) * Modify semver.py to not use packaging.version.parse * Changie (cherry picked from commit d9424cc) * Fix regression in semver comparison logic (#7040) (#7041) (cherry picked from commit 915585c) * Fix changed name of exception --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7039
Description
If this looks good, we need to:
1.4.latestChecklist
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PRchangie newto create a changelog entry