Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set relation_name in tests at compile time #6949

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Set relation_name in tests at compile time #6949

merged 3 commits into from
Feb 14, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Feb 11, 2023

resolves #6930

Description

After moving the setting of relation_name to parse time, test nodes do not contain relation_name when store_failures is set by cli param.

Checklist

@gshank gshank requested a review from a team February 11, 2023 00:44
@gshank gshank requested a review from a team as a code owner February 11, 2023 00:44
@gshank gshank requested review from aranke and mikealfare February 11, 2023 00:44
@cla-bot cla-bot bot added the cla:yes label Feb 11, 2023
@gshank gshank marked this pull request as draft February 13, 2023 17:06
@gshank gshank marked this pull request as ready for review February 13, 2023 18:38
@gshank gshank requested review from peterallenwebb and emmyoop and removed request for aranke February 13, 2023 18:38
@gshank gshank merged commit 480e0e5 into main Feb 14, 2023
@gshank gshank deleted the ct-2083-test_relation_name branch February 14, 2023 16:32
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Feb 14, 2023
@gshank @github-actions
Set relation_name in tests at compile time (#6949)
1a2dd96 
(cherry picked from commit 480e0e5)
gshank added a commit that referenced this pull request Feb 14, 2023
@github-actions @gshank
[Backport 1.4.latest] Set relation_name in tests at compile time (#6978)
16cb498 
* Set relation_name in tests at compile time (#6949)

(cherry picked from commit 480e0e5)

* Tweak artifact test

---------

Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare left review comments

@peterallenwebb peterallenwebb peterallenwebb approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop

Assignees
No one assigned
Labels
backport 1.4.latest cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2083] [Bug] Store failures log message keeps reporting the failures table as None
3 participants
@gshank @peterallenwebb @mikealfare