Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] fix contributor list generation (#6799) #6808

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 31, 2023

Backport #6374 #6799

Necessary to allow other back ports to work without conflicts. Since PR is no longer required on main, when a change is back ported it will not have the PR in the changelog yaml and will break changelog generation.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jan 31, 2023
@emmyoop emmyoop requested a review from a team as a code owner January 31, 2023 19:32
@cla-bot cla-bot bot added the cla:yes label Jan 31, 2023
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say LGTM but that code is obtuse, wow! Bet you had "fun" trudging through that.

@emmyoop emmyoop merged commit 31bfff8 into 1.4.latest Feb 1, 2023
@emmyoop emmyoop deleted the backport/1.4.latest-ct-1562 branch February 1, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants