Remove UnsetProfileConfig

[MichelleArk]

resolves #5539

Description

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[stu-k]

Nothing stands out 👍

[gshank]

I suspect that MP_CONTEXT should not be in the Flags object. It's not really a flag, and it's not serializable. I had to jump through some hoops to prevent it from serializing a while back. I'm not sure where it would be best to put it. And it's another global thing...

[jtcohen6]

I suspect that MP_CONTEXT should not be in the Flags object. It's not really a flag, and it's not serializable. I had to jump through some hoops to prevent it from serializing a while back. I'm not sure where it would be best to put it. And it's another global thing...

@gerda MP_CONTEXT - gosh - there's some gnarliness here:

dbt-core/core/dbt/flags.py

Lines 120 to 126 in 8217ad4

	def _get_context():
	# TODO: change this back to use fork() on linux when we have made that safe
	return multiprocessing.get_context("spawn")
	# This is not a flag, it's a place to store the lock
	MP_CONTEXT = _get_context()

Agree it really doesn't belong on the flags object / module. It's probably just there because that's where we've historically stuck a lot of our globals. It does seem to be used for locks within dbt-core (when things need to be thread-safe), and also within dbt-rpc.

That looks unrelated to the changes in this PR, though?

[gshank]

I tried looking through some of the test failures and in at least one case I saw an error about "unable to serialize SpawnContext", which is from that. The test output started disappearing though...

[MichelleArk]

I tried looking through some of the test failures and in at least one case I saw an error about "unable to serialize SpawnContext", which is from that. The test output started disappearing though...

@gshank - Thank you for looking into the type TypeError: Object of type SpawnContext is not JSON serializable errors, and for the additional context @jtcohen6! Integration tests on the feature/click-cli branch are expected to fail since we started running integration tests through the new click framework which is under development and still missing large portions of its implementation. This issue does feel out of scope for this PR but I've opened an issue to track it as part of the API-ification epic: #6509.

[iknox-fa]

LGTM!

[iknox-fa]

I tried looking through some of the test failures and in at least one case I saw an error about "unable to serialize SpawnContext", which is from that. The test output started disappearing though...

@gshank - Thank you for looking into the type TypeError: Object of type SpawnContext is not JSON serializable errors, and for the additional context @jtcohen6! Integration tests on the feature/click-cli branch are expected to fail since we started running integration tests through the new click framework which is under development and still missing large portions of its implementation. This issue does feel out of scope for this PR but I've opened an issue to track it as part of the API-ification epic: #6509.

+100 from my POV. I think this one falls into the overarching de-globalization effort that @ChenyuLInx will be working on at some point as tech-lead of the "gap work" for dbt-server.