profile work in click #6303
Closed
profile work in click #6303
+79
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
commented
Nov 22, 2022
| @@ -48,6 +48,25 @@ def load_project( | |||
| return project | |||
|
|
|||
|
|
|||
| def load_profile( | |||
There was a problem hiding this comment.
@MichelleArk I imagine we would use something like this to generate the profile object, we maybe should refactor this code to pass in a loaded project dict directly instead of reading from disk, that way we can reuse that loaded project to also construct project object
MichelleArk
reviewed
Nov 22, 2022
MichelleArk
reviewed
Nov 23, 2022
|
Looks like the failing tests are all of the flavor: and just need some refactoring to conform to the new signature for Otherwise looks good! |
MichelleArk
approved these changes
Nov 23, 2022
|
@iknox-fa @MichelleArk gonna close this in favor of #6336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Description
Checklist
changie newto create a changelog entry