Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Force tox to update pip (fixes psycopg2-binary @ 2.9.5) #6134

Merged
merged 3 commits into from
Oct 25, 2022
Merged

[BUGFIX] Force tox to update pip (fixes psycopg2-binary @ 2.9.5) #6134

merged 3 commits into from
Oct 25, 2022

Conversation

iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Oct 25, 2022 •
edited
Loading

resolves #6135

Description

It appears hat there's a bug in the latest version of psycopg2-binary (2.9.5) when installing in tox + windows + pip @ 22.2.2

This PR changes our tox config to always update pip on each run (something we should probably do anyway).

Checklist

@iknox-fa iknox-fa requested a review from a team as a code owner October 25, 2022 17:10
@cla-bot cla-bot bot added the cla:yes label Oct 25, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@iknox-fa iknox-fa added the Skip Changelog Skips GHA to check for changelog file label Oct 25, 2022
@iknox-fa iknox-fa requested a review from a team as a code owner October 25, 2022 17:19
@iknox-fa iknox-fa requested a review from MichelleArk October 25, 2022 17:19
@iknox-fa iknox-fa changed the title [BUGFIX] Pin psycopg2-binary to 2.9.4 [BUGFIX] Force tox to update pip (fixes issue with psycopg2-binary @ 2.9.5) Oct 25, 2022
@iknox-fa iknox-fa changed the title [BUGFIX] Force tox to update pip (fixes issue with psycopg2-binary @ 2.9.5) [BUGFIX] Force tox to update pip (fixes psycopg2-binary @ 2.9.5) Oct 25, 2022
@iknox-fa iknox-fa merged commit c285601 into main Oct 25, 2022
@iknox-fa iknox-fa deleted the iknox/test-broken-psycopg2 branch October 25, 2022 18:01
@iknox-fa iknox-fa restored the iknox/test-broken-psycopg2 branch October 25, 2022 18:05
@iknox-fa iknox-fa mentioned this pull request Oct 25, 2022
Merged
@iknox-fa iknox-fa deleted the iknox/test-broken-psycopg2 branch October 25, 2022 18:32
@leahwicz
Copy link
Contributor

@iknox-fa thanks for the quick response here!

@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stu-k stu-k stu-k approved these changes

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt was automatically assigned from dbt-labs/adapters

@MichelleArk MichelleArk Awaiting requested review from MichelleArk MichelleArk was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1398] [Bug] Psycopg2-binary + pip@22.2.2 = broken installs
3 participants
@iknox-fa @leahwicz @stu-k