Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar improvement when more than one model per file #6048

Closed
wants to merge 1 commit into from

Conversation

AndrewLane
Copy link

Description

Grammar improvement to error message when more than model is defined in a file

Checklist

  • [ x ] I have read the contributing guide and understand what's expected of me
  • [ x ] I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • [ x ] This PR includes tests, or tests are not required/relevant for this PR
  • [ x ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@AndrewLane AndrewLane requested a review from a team as a code owner October 11, 2022 18:39
@cla-bot
Copy link

cla-bot bot commented Oct 11, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @AndrewLane

@AndrewLane
Copy link
Author

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @AndrewLane

Just signed it

@AndrewLane AndrewLane closed this Oct 11, 2022
@AndrewLane
Copy link
Author

Re-opening to see if the bot will refresh the status

@AndrewLane AndrewLane reopened this Oct 11, 2022
@jtcohen6
Copy link
Contributor

@AndrewLane Sorry we missed this! It looks like the same improvement was flagged over in #6245 / #6251. I'm going to close this PR in favor of that one, but you'll get credit in my book for being the first to propose the fix.

@jtcohen6 jtcohen6 closed this Nov 17, 2022
@AndrewLane AndrewLane deleted the patch-1 branch November 17, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants