Follow-up to #5334 #5382
Merged
Follow-up to #5334 #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
approved these changes
Jun 17, 2022
| @@ -1,5 +1,5 @@ | |||
| kind: Under the Hood | |||
| body: Update context readme + clean up context code" | |||
| kind: Security | |||
There was a problem hiding this comment.
nit: This won't change how the changelog markdown gets generated but for consistency can we change the file name to be Security-20220606-230353.yaml? For context, the filenames are just like this for uniqueness, they don't actually get any fields out of the name.
| @@ -14,6 +14,7 @@ kinds: | |||
| - label: Docs | |||
| - label: Under the Hood | |||
| - label: Dependencies | |||
| - label: Security | |||
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-5382-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d5608dca322c63f1a894174b1f280ae55a217ab8
# Push it to GitHub
git push --set-upstream origin backport-5382-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latestThen, create a pull request where the |
jtcohen6
added a commit
that referenced
this pull request
Jun 28, 2022
jtcohen6
added a commit
that referenced
this pull request
Jun 28, 2022
jtcohen6
added a commit
that referenced
this pull request
Jun 28, 2022
jtcohen6
added a commit
that referenced
this pull request
Jun 28, 2022
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* Follow-up to secret rendering changes * Update changelog entries * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
render_valuemethod (reimplemented forSecretRenderer)I'll backport to
1.1.latest+1.0.latestafter merging. The test case requires a teensy bit of modification to work in v1.0 (old testing framework), but it passes for me locally there as well.