task init: support older click v7.0 #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @twilly |
`dbt init` uses click for interactively setting up a project. The version constraints currently ask for click >= 8 but v7.0 has nearly the same prompt/confirm/echo API. prompt added a feature that isn't used. confirm has a behavior change if the default is None, but confirm(..., default=None) is not used. Long story short, we can relax the version constraint to allow installing with an older click library. Ref: Issue dbt-labs#4566
1 task
Co-authored-by: Chenyu Li <chenyulee777@gmail.com>
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* task init: support older click v7.0 `dbt init` uses click for interactively setting up a project. The version constraints currently ask for click >= 8 but v7.0 has nearly the same prompt/confirm/echo API. prompt added a feature that isn't used. confirm has a behavior change if the default is None, but confirm(..., default=None) is not used. Long story short, we can relax the version constraint to allow installing with an older click library. Ref: Issue #4566 * Update CHANGELOG.md Co-authored-by: Chenyu Li <chenyulee777@gmail.com> Co-authored-by: Chenyu Li <chenyulee777@gmail.com> automatic commit by git-black, original commits: 72ecd1c
leahwicz
pushed a commit
that referenced
this pull request
Mar 3, 2022
* task init: support older click v7.0 `dbt init` uses click for interactively setting up a project. The version constraints currently ask for click >= 8 but v7.0 has nearly the same prompt/confirm/echo API. prompt added a feature that isn't used. confirm has a behavior change if the default is None, but confirm(..., default=None) is not used. Long story short, we can relax the version constraint to allow installing with an older click library. Ref: Issue #4566 * Update CHANGELOG.md Co-authored-by: Chenyu Li <chenyulee777@gmail.com> Co-authored-by: Chenyu Li <chenyulee777@gmail.com>
4 tasks
leahwicz
added a commit
that referenced
this pull request
Mar 9, 2022
* task init: support older click v7.0 `dbt init` uses click for interactively setting up a project. The version constraints currently ask for click >= 8 but v7.0 has nearly the same prompt/confirm/echo API. prompt added a feature that isn't used. confirm has a behavior change if the default is None, but confirm(..., default=None) is not used. Long story short, we can relax the version constraint to allow installing with an older click library. Ref: Issue #4566 * Update CHANGELOG.md Co-authored-by: Chenyu Li <chenyulee777@gmail.com> Co-authored-by: Chenyu Li <chenyulee777@gmail.com> Co-authored-by: Tristan Willy <twilly@users.noreply.github.com> Co-authored-by: Chenyu Li <chenyulee777@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbt inituses click for interactively setting up a project. Theversion constraints currently ask for click >= 8 but v7.0 has nearly the
same prompt/confirm/echo API. prompt added a feature that isn't used.
confirm has a behavior change if the default is None, but
confirm(..., default=None) is not used. Long story short, we can relax
the version constraint to allow installing with an older click library.
Ref: Issue #4566
Checklist
CHANGELOG.mdand added information about my change