version logging #4289
Merged
version logging #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
26 tasks
emmyoop
reviewed
Nov 19, 2021
core/dbt/events/functions.py
Outdated
| 'ts': e.get_ts(), | ||
| 'pid': e.get_pid(), | ||
| 'msg': msg_fn(e), | ||
| 'level': level if len(level) == 5 else f"{level} " |
There was a problem hiding this comment.
Since this is for the json output we don't want to format the level here. Just in the text.
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* start adding version logging, noticed some wrong stuff * fix bad pid and ts * remove level format on json logs Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> automatic commit by git-black, original commits: 726aba0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds versioning to events and does some minor cleanup like making time stamps and pids actually work.
Checklist
CHANGELOG.mdand added information about my change