Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3689] Fix filesystem searcher and tests that mock it #4271

Merged
merged 1 commit into from
Nov 15, 2021
Merged

[#3689] Fix filesystem searcher and tests that mock it #4271

merged 1 commit into from
Nov 15, 2021

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 11, 2021

resolves #3689

Description

With Python 3.9 we were getting a unit test failure which was due to a leftover mock from a different test. The reason for this isn't totally clear; it might possibly be a Python bug, but isn't worth chasing down. This converts the filesystem searcher to a simple function and changes the mock to explicitly be on the function used in test_graph.py.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 11, 2021
@gshank gshank force-pushed the fix_filesystem_searcher branch from 74d1736 to d0171b0 Compare November 11, 2021 14:22
@gshank gshank requested review from kwigley and jtcohen6 November 11, 2021 14:22
jtcohen6
jtcohen6 reviewed Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Could we turn on unit tests for 3.9 in CI, to verify this works (and have full testing on py39 going forward)?

dbt-core/.github/workflows/main.yml

Line 80 in 0722922

python-version: [3.7, 3.8] # TODO: support unit testing for python 3.9 (https://github.com/dbt-labs/dbt/issues/3689)

@gshank gshank force-pushed the fix_filesystem_searcher branch from d0171b0 to 28d940b Compare November 15, 2021 14:17
@gshank gshank requested a review from jtcohen6 November 15, 2021 14:30
@gshank gshank merged commit 3d28b67 into main Nov 15, 2021
@gshank gshank deleted the fix_filesystem_searcher branch November 15, 2021 14:46
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@gshank @iknox-fa
[#3689] Fix filesystem searcher and tests that mock it (#4271)
28d4692 
automatic commit by git-black, original commits:
  2cc0579
  3d28b67
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@gshank @iknox-fa
[#3689] Fix filesystem searcher and tests that mock it (#4271)
7587e14 
automatic commit by git-black, original commits:
  3d28b67
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@gshank @iknox-fa
[#3689] Fix filesystem searcher and tests that mock it (#4271)
db3f37a 
automatic commit by git-black, original commits:
  3d28b67
  d246bab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@kwigley kwigley kwigley approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address issue with python3.9 unit testing and turn on by default
3 participants
@gshank @kwigley @jtcohen6