Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue message instead of exception when patch does not have a matching node #4236

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Issue message instead of exception when patch does not have a matching node #4236

merged 1 commit into from
Nov 8, 2021

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 8, 2021

resolves #3885

Description

Implementation of the env var partial parsing code included a change to throw an exception when there is no matching node for a patch. This reverts that and switches to issuing a message.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 8, 2021
@gshank gshank requested a review from jtcohen6 November 8, 2021 19:13
jtcohen6
jtcohen6 reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work! One small comment, otherwise good to go

core/dbt/parser/schemas.py Outdated Show resolved Hide resolved
@gshank gshank force-pushed the only_warn_for_missing_patch_node branch from 793131d to 2cbc5b9 Compare November 8, 2021 19:31
@gshank gshank requested a review from jtcohen6 November 8, 2021 19:31
@jtcohen6 jtcohen6 mentioned this pull request Nov 8, 2021
Closed
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 8, 2021

I'm just running the dbt-adapter-tests suite with dbt-spark to be extra sure that this change will fix integration tests over there. I hoped to do it in CircleCI, but they're having a major outage right now, so I'm doing it locally (and slowly) instead. As soon as that happens, I'll give final approval and we can merge.

jtcohen6
jtcohen6 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@gshank gshank merged commit e94fd61 into main Nov 8, 2021
@gshank gshank deleted the only_warn_for_missing_patch_node branch November 8, 2021 20:35
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@gshank @iknox-fa
Issue message instead of exception when patch does not have a matching (
c5a7400 
#4236) node

automatic commit by git-black, original commits:
  e94fd61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Env vars + partial parsing
2 participants
@gshank @jtcohen6