Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unique_key to take a list #4159

Conversation

triedandtested-dev
Copy link
Contributor

@triedandtested-dev triedandtested-dev commented Oct 28, 2021

resolves #2479

Description

  • Support for unique_key can be a string or a list.
  • merge macro support for a unique key being a list.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot
Copy link

cla-bot bot commented Oct 28, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bryan Dunkley.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 5, 2021

@triedandtested-dev Do you think you'll be able to sign the CLA? If so, I'd still love to have this change, and the corresponding changes to the default macro implementations in merge.sql as well :)

`unique_key` can be a string or a list.
extend the functionality to support both single and multiple keys

Signed-off-by: triedandtested-dev (Bryan Dunkley) <bryan@triedandtested.dev>
@triedandtested-dev triedandtested-dev force-pushed the feature/2479-unique-key-to-take-a-list branch from a7454ca to 90f13d3 Compare November 14, 2021 19:41
@cla-bot cla-bot bot added the cla:yes label Nov 14, 2021
@triedandtested-dev triedandtested-dev changed the title Add unique_key to NodeConfig Allow unique_key to take a list Nov 14, 2021
Signed-off-by: triedandtested-dev (Bryan Dunkley) <bryan@triedandtested.dev>
Signed-off-by: triedandtested-dev (Bryan Dunkley) <bryan@triedandtested.dev>
@triedandtested-dev triedandtested-dev force-pushed the feature/2479-unique-key-to-take-a-list branch from 010a2ed to ea9cbb1 Compare November 14, 2021 20:35
@JCZuurmond
Copy link
Contributor

What is the status of this PR? I see some failed CI's and not development for two months on this

@arun-anilkumar
Copy link

What is the status of this PR? I see some failed CI's and not development for two months on this

Can we have an update please on whats holding this up?

@triedandtested-dev
Copy link
Contributor Author

triedandtested-dev commented Jan 24, 2022 via email

@gshank
Copy link
Contributor

gshank commented Jan 24, 2022

Bryan: Since you don't have time right now to finish this off, would you mind if we took it over? It would be nice to get it merged.

@triedandtested-dev
Copy link
Contributor Author

triedandtested-dev commented Jan 24, 2022 via email

@gshank
Copy link
Contributor

gshank commented Jan 24, 2022

Thanks!

Note: we'd like to avoid having to update the artifact json schema for this change. See: #4617

@gshank
Copy link
Contributor

gshank commented Jan 24, 2022

This pull request has been replaced by #4618

@gshank gshank closed this Jan 24, 2022
@triedandtested-dev triedandtested-dev deleted the feature/2479-unique-key-to-take-a-list branch January 26, 2022 22:42
@dbeatty10 dbeatty10 mentioned this pull request Dec 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-96] Allow unique_key for incremental materializations to take a list
5 participants