-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unique_key to take a list #4159
Allow unique_key to take a list #4159
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bryan Dunkley.
|
@triedandtested-dev Do you think you'll be able to sign the CLA? If so, I'd still love to have this change, and the corresponding changes to the default macro implementations in |
`unique_key` can be a string or a list.
extend the functionality to support both single and multiple keys Signed-off-by: triedandtested-dev (Bryan Dunkley) <bryan@triedandtested.dev>
a7454ca
to
90f13d3
Compare
Signed-off-by: triedandtested-dev (Bryan Dunkley) <bryan@triedandtested.dev>
Signed-off-by: triedandtested-dev (Bryan Dunkley) <bryan@triedandtested.dev>
010a2ed
to
ea9cbb1
Compare
What is the status of this PR? I see some failed CI's and not development for two months on this |
Can we have an update please on whats holding this up? |
Currently I haven’t had capacity to look into this due to project
commitments.
On Mon, 24 Jan 2022 at 14:53, arun-anilkumar ***@***.***> wrote:
What is the status of this PR? I see some failed CI's and not development
for two months on this
Can we have an update please on whats holding this up?
—
Reply to this email directly, view it on GitHub
<#4159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5ZJ6L7DJMTMS7LKCZOT3LUXVRUZANCNFSM5G5VOJTQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Bryan Dunkley
|
Bryan: Since you don't have time right now to finish this off, would you mind if we took it over? It would be nice to get it merged. |
Not at all. You are welcome to take it over.
On Mon, 24 Jan 2022 at 17:14, Gerda Shank ***@***.***> wrote:
Bryan: Since you don't have time right now to finish this off, would you
mind if we took it over? It would be nice to get it merged.
—
Reply to this email directly, view it on GitHub
<#4159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5ZJ6KETFZCTTTMWMRYDNDUXWCGZANCNFSM5G5VOJTQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Bryan Dunkley
|
Thanks! Note: we'd like to avoid having to update the artifact json schema for this change. See: #4617 |
This pull request has been replaced by #4618 |
resolves #2479
Description
unique_key
can be a string or a list.Checklist
CHANGELOG.md
and added information about my change