Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 4070 #4080

Merged
merged 5 commits into from
Oct 22, 2021
Merged

[Backport] 4070 #4080

merged 5 commits into from
Oct 22, 2021

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 15, 2021

Backport #4074 4070

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

* fixed error_id typo and added tests

* added changelog entry
# Conflicts:
#	CHANGELOG.md
@cla-bot cla-bot bot added the cla:yes label Oct 15, 2021
@emmyoop emmyoop closed this Oct 15, 2021
@emmyoop emmyoop reopened this Oct 22, 2021
@emmyoop emmyoop changed the title Backport 4070 v2 [Backport] 4070 Oct 22, 2021
@emmyoop emmyoop changed the base branch from main to 0.21.latest October 22, 2021 00:35
@emmyoop emmyoop requested a review from leahwicz October 22, 2021 00:35
@emmyoop emmyoop merged commit c66a82b into 0.21.latest Oct 22, 2021
@emmyoop emmyoop deleted the backport-4070-v2 branch October 22, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants