Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust logic when finding approx matches for model or test matching #4076

Merged
merged 6 commits into from
Nov 29, 2021
Merged

Adjust logic when finding approx matches for model or test matching #4076

merged 6 commits into from
Nov 29, 2021

Conversation

emilieschario
Copy link
Contributor

@emilieschario emilieschario commented Oct 15, 2021 •
edited
Loading

resolves # #3835

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: emilie.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@dataders dataders mentioned this pull request Nov 2, 2021
Closed
1 task
dataders added a commit to firebolt-db/dbt-firebolt that referenced this pull request Nov 3, 2021
@dataders
from dbt-labs/dbt-core#4076
1fe057d
dataders added a commit to firebolt-db/dbt-firebolt that referenced this pull request Nov 3, 2021
@dataders
from dbt-labs/dbt-core#4076
eb03a3a
@dataders dataders mentioned this pull request Nov 3, 2021
Closed
@cla-bot cla-bot bot added the cla:yes label Nov 24, 2021
@emilieschario emilieschario changed the title WIP: Adjust logic when finding approx matches Adjust logic when finding approx matches for model or test matching Nov 24, 2021
@emilieschario
Copy link
Contributor Author

@jtcohen6 the failing flake 8 test seems unrelated (it's whitespace related on a file I'm not editing?) Is it okay to ignore?

@emilieschario @jtcohen6
Update core/dbt/adapters/base/relation.py
c0a96a3 
Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
@emilieschario
Copy link
Contributor Author

I completely misread the error 🤦‍♀️ . thanks @jtcohen6

jtcohen6
jtcohen6 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emilieschario :)

@jtcohen6 jtcohen6 merged commit ed1ff2c into dbt-labs:main Nov 29, 2021
@jtcohen6 jtcohen6 mentioned this pull request Feb 2, 2022
Closed
5 tasks
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@emilieschario @iknox-fa
Adjust logic when finding approx matches for model or test matching (#…
bc9b0b6 
…4076)

* adjust logic when finding approx matches

* update changelog

* Update core/dbt/adapters/base/relation.py

Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>

* Update changelog

Co-authored-by: Jeremy Cohen <jtcohen6@gmail.com>
Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>

automatic commit by git-black, original commits:
  ed1ff2c
@jtcohen6 jtcohen6 mentioned this pull request May 11, 2022
Closed
1 task
@jtcohen6 jtcohen6 mentioned this pull request Feb 3, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
cla:yes ok_to_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilieschario @jtcohen6