enacted deprecation for dispatch-packages, cleaned up deprecations te… #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b21849 to
41b8929
Compare
…sts for unused macros/models. still need to clean up unused code.
41b8929 to
7414b4c
Compare
leahwicz
approved these changes
Oct 5, 2021
jtcohen6
approved these changes
Oct 5, 2021
| @@ -142,84 +135,20 @@ def statically_parse_adapter_dispatch(func_call, ctx, db_wrapper): | |||
| elif packages_arg_type == 'Const': | |||
| # This will remain to enable static resolution | |||
| macro_namespace = packages_arg.value | |||
| elif packages_arg_type == 'Call': | |||
There was a problem hiding this comment.
adieu ! you served us well
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
#3975) * enacted deprecation for dispatch-packages, cleaned up deprecations tests for unused macros/models. still need to clean up unused code. * more work to catch packages use * fixed tests for removing packages on adapter.dispatch. * cleaned out folder for 012_deprecation_tests to remove unused models/data/macros * removed obsolete code due to patching for packages arg in adapter.dispatch * updated exception name * added deprecation change to changelog. automatic commit by git-black, original commits: 3caec08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3895
Description
Raise an exception when using the packages argument in
adapter.dispatch()and removed associated tests/warnings.Still need to remove code that enabled backwards compatibility.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.