deepcopy args when passed down to rpc pask #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37513e0 to
1312243
Compare
1312243 to
eded923
Compare
|
Do you think we should remove the deepcopy from the RemoteMethod init method in core/dbt/rpc/method.py? I guess it doesn't hurt, but it is an extra copy now. |
@gshank good point, I'll remove it. It can be pretty expensive operation. I also like knowing that the object owns the args passed in, instead of creating a copy in the constructor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also resolves #3846
Description
This makes sure that RPC tasks are initialized with a copy of
self.args. IF they are mutated further down the call stack, it won't affect the high level RPC process management task and be passed to subsequent RPC tasks.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.