Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the new makefile on macos #2768

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix the new makefile on macos #2768

merged 1 commit into from
Sep 17, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Sep 17, 2020 •
edited
Loading

Description

Have make touch .env before making it, and bypass making a .env file on macos (and Windows, though I doubt this works on Windows in general).

This also suppresses a related warning.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • [] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Sep 17, 2020
@beckjake beckjake changed the base branch from dev/kiyoshi-kuromiya to dev/0.18.1 September 17, 2020 17:49
@beckjake beckjake requested a review from gshank September 17, 2020 17:49
@beckjake beckjake merged commit 1fc5a45 into dev/0.18.1 Sep 17, 2020
@beckjake beckjake deleted the fix/makefile-on-macos branch September 17, 2020 19:42
@beckjake beckjake mentioned this pull request Sep 18, 2020
Closed
@jtcohen6 jtcohen6 mentioned this pull request Dec 3, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckjake @gshank