[TIDY FIRST] Click option defintiion organization (alphabetization) #11236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #N/A because it's a tidy first
Problem
The organization of click option definitions in
cli/params.py
was a weird mixture of some alphabetization, new options getting added to the EOF, and grouping by feature. This mean the only way to find an option was to do a text search which was annoying. It also made it confusing as to where a new option should get added. Alphabetically? To the end of the file? Was there some similar option that the new option should be "near"?Solution
Alphabetize the click option definitions.
Checklist