Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error counts for exposures #11207

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix error counts for exposures #11207

merged 1 commit into from
Jan 10, 2025

Conversation

aranke
Copy link
Member

@aranke aranke commented Jan 10, 2025

Problem

Skipped exposures should not be added to errors list.

Solution

Don't do that.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (e4d5a4e) to head (2f753d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11207      +/-   ##
==========================================
+ Coverage   88.91%   88.93%   +0.02%     
==========================================
  Files         187      187              
  Lines       24104    24112       +8     
==========================================
+ Hits        21432    21444      +12     
+ Misses       2672     2668       -4     
Flag Coverage Δ
integration 86.31% <93.75%> (+0.09%) ⬆️
unit 62.40% <31.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.40% <31.25%> (+<0.01%) ⬆️
Integration Tests 86.31% <93.75%> (+0.09%) ⬆️

@aranke aranke marked this pull request as ready for review January 10, 2025 20:33
@aranke aranke requested a review from a team as a code owner January 10, 2025 20:33
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@aranke aranke merged commit 8a8857a into main Jan 10, 2025
63 of 64 checks passed
@aranke aranke deleted the fix_exposure_error_counts branch January 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants