Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--inline-direct is an internal CLI flag #10806

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 1, 2024

Resolves NA

Problem

--inline-direct introduced in #10770 is an internal CLI flag, but it will display via --help

Solution

Two-part solution per discussion with @graciegoheen:

  1. Describe it as an internal flag
  2. Remove it from display via --help

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • Tests are not required or relevant for this PR.
  • This PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@dbeatty10 dbeatty10 requested a review from a team as a code owner October 1, 2024 19:23
@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (396cf2d) to head (cfb10f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10806      +/-   ##
==========================================
- Coverage   89.21%   89.17%   -0.05%     
==========================================
  Files         183      183              
  Lines       23457    23457              
==========================================
- Hits        20928    20917      -11     
- Misses       2529     2540      +11     
Flag Coverage Δ
integration 86.41% <ø> (-0.13%) ⬇️
unit 62.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.09% <ø> (ø)
Integration Tests 86.41% <ø> (-0.13%) ⬇️

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Oct 1, 2024
@dbeatty10 dbeatty10 merged commit 3ec8fa7 into main Oct 1, 2024
75 of 78 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty/inline-direct-hidden-help-message branch October 1, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants