Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded TODO #10568

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Remove unneeded TODO #10568

merged 1 commit into from
Aug 14, 2024

Conversation

courtneyholcomb
Copy link
Contributor

Just removing a TODO that is no longer needed. The docs link is staying the same so there is no change needed here.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@courtneyholcomb courtneyholcomb added the Skip Changelog Skips GHA to check for changelog file label Aug 14, 2024
@courtneyholcomb courtneyholcomb requested a review from a team as a code owner August 14, 2024 21:24
@cla-bot cla-bot bot added the cla:yes label Aug 14, 2024
@github-actions github-actions bot added the community This PR is from a community member label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (5f66678) to head (dfcfb1e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10568      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.01%     
==========================================
  Files         180      180              
  Lines       22735    22735              
==========================================
- Hits        20220    20218       -2     
- Misses       2515     2517       +2     
Flag Coverage Δ
integration 86.25% <ø> (ø)
unit 62.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.37% <ø> (ø)
Integration Tests 86.25% <ø> (ø)

@MichelleArk MichelleArk merged commit 9ca1bc5 into main Aug 14, 2024
78 checks passed
@MichelleArk MichelleArk deleted the court/todo branch August 14, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants