Use common columns for incremental schema changes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
a230017 to
cb026c9
Compare
4 tasks
29fea7d to
fa7d257
Compare
jtcohen6
reviewed
Nov 7, 2021
fa7d257 to
64492a0
Compare
3aad884 to
1c1b9bf
Compare
jtcohen6
reviewed
Nov 8, 2021
| @@ -87,6 +87,21 @@ def run_incremental_append_new_columns(self): | |||
| self.list_tests_and_assert(select, exclude, expected) | |||
| self.run_tests_and_assert(select, exclude, expected, compare_source, compare_target) | |||
|
|
|||
| def run_incremental_append_new_columns_remove_one(self): | |||
There was a problem hiding this comment.
Add to test below:
@use_profile('bigquery')
def test__bigquery__run_incremental_append_new_columns(self):
self.run_incremental_append_new_columns()
self.run_incremental_append_new_columns_remove_one()There was a problem hiding this comment.
Indeed I missed that 😵💫
I updated it 👍
1c1b9bf to
f72116c
Compare
siephen
pushed a commit
to AgencyPMG/dbt-bigquery
that referenced
this pull request
May 16, 2022
* Use common columns for incremental schema changes * Review changes * Follow up change for lean return version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#4144
Description
Using dbt-labs/dbt-core#4170 changes, the goal is to retrieve the intersection from existing table columns and the tmp table columns for the condition to avoid referencing columns that wouldn't be in one or the other table and lead to a failure of the incremental run.
Snowflake equivalent: dbt-labs/dbt-snowflake#38
Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.