Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array macros #308

Merged
merged 11 commits into from
Sep 26, 2022
Merged

Array macros #308

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f79579
Temporary dev-requirements
dbeatty10 Sep 13, 2022
d3374a6
Changelog entry
dbeatty10 Sep 13, 2022
9af9050
Implementations and tests for array macros
dbeatty10 Sep 13, 2022
6152736
Merge branch 'main' into dbeatty/lift-shift-array-macros
dbeatty10 Sep 13, 2022
c48e032
Remove `cast_array_to_string` macro
dbeatty10 Sep 22, 2022
2e00ec9
Merge branch 'main' into dbeatty/lift-shift-array-macros
dbeatty10 Sep 22, 2022
27125b2
Merge branch 'main' into dbeatty/lift-shift-array-macros
dbeatty10 Sep 23, 2022
5c34cbc
Merge branch 'dbeatty/lift-shift-array-macros' of github.com:dbt-labs…
dbeatty10 Sep 23, 2022
8242425
ARRAY in BigQuery does not support set operation comparisons using EX…
dbeatty10 Sep 24, 2022
739d1ea
Restore original dev-requirements.txt
dbeatty10 Sep 26, 2022
8080835
Merge branch 'main' into dbeatty/lift-shift-array-macros
dbeatty10 Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Features-20220913-084836.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Features
body: Array macros
time: 2022-09-13T08:48:36.255365-06:00
custom:
Author: graciegoheen dbeatty10
Issue: "307"
PR: "308"
3 changes: 3 additions & 0 deletions dbt/include/bigquery/macros/utils/array_append.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{% macro bigquery__array_append(array, new_element) -%}
{{ array_concat(array, array_construct([new_element])) }}
{%- endmacro %}
3 changes: 3 additions & 0 deletions dbt/include/bigquery/macros/utils/array_concat.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{% macro bigquery__array_concat(array_1, array_2) -%}
array_concat({{ array_1 }}, {{ array_2 }})
{%- endmacro %}
3 changes: 3 additions & 0 deletions dbt/include/bigquery/macros/utils/array_construct.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{% macro bigquery__array_construct(inputs, data_type) -%}
[ {{ inputs|join(' , ') }} ]
{%- endmacro %}
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@dbeatty/lift-shift-array-macros#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@dbeatty/lift-shift-array-macros#egg=dbt-tests-adapter&subdirectory=tests/adapter

black==22.8.0
bumpversion
Expand Down
17 changes: 16 additions & 1 deletion tests/functional/adapter/utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import pytest
from dbt.tests.adapter.utils.base_utils import BaseUtils

from dbt.tests.adapter.utils.test_array_append import BaseArrayAppend
from dbt.tests.adapter.utils.test_array_concat import BaseArrayConcat
from dbt.tests.adapter.utils.test_array_construct import BaseArrayConstruct
from dbt.tests.adapter.utils.test_any_value import BaseAnyValue
from dbt.tests.adapter.utils.test_bool_or import BaseBoolOr
from dbt.tests.adapter.utils.test_cast_bool_to_text import BaseCastBoolToText
Expand Down Expand Up @@ -27,6 +30,18 @@ class TestAnyValue(BaseAnyValue):
pass


class TestArrayAppend(BaseArrayAppend):
pass


class TestArrayConcat(BaseArrayConcat):
pass


class TestArrayConstruct(BaseArrayConstruct):
pass


class TestBoolOr(BaseBoolOr):
pass

Expand Down