-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Python 3.10 to test matrix #177
Conversation
You can't add an init.py file underneath the 'dbt' directory. It breaks the plugin architecture. |
@@ -0,0 +1,3 @@ | |||
from pkgutil import extend_path | |||
|
|||
__path__ = extend_path(__path__, __name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I've read changing path this way is uncommon. What's the reason here? Super curious about the use case. edit: Does it have to do with Gerda's comment by chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a convo in Slack here about it but the TLDR is that we reuse dbt
namespace twice which confuses mypy. This helps just combine them for mypy to reference. In the long run, we should refactor the codebase to not have this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a previous effort, I played around with notions of mypy's added stub feature. I opted away from this after having several nontrivial process questions. Instead, I type: ignore
-ed several things.
Here are some questions that come to mind:
- where all the agate stubs you've included came from!
- How do we purpose to keep this up to date with the changing library specification?
- What's the update procedure?
Good questions Mila!
I copied them from
In the majority of the cases, we should use the associated types package for each of these dependencies. I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, not seeing any red-flags sticking out in the types
Description
This change started out as Python 3.10 support but then grew some. With this change, we now will have:
Checklist
CHANGELOG.md
and added information about my change to the "dbt-bigquery next" section.