Make sure partition_by is in config if setting require_partition_filter #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hui-zheng
reviewed
Jan 26, 2022
|
@oliverrmaa seems you may be behind |
|
@McKnight-42 , okay no problem, I have updated the branch to be up to date with |
McKnight-42
approved these changes
Jan 28, 2022
siephen
pushed a commit
to AgencyPMG/dbt-bigquery
that referenced
this pull request
May 16, 2022
…er (dbt-labs#109) * initial commit * update changelog * fix typo in changelog * Hui's feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #107
Description
This PR adds an additional condition in
get_table_optionsforrequire_partition_filter. Essentially, both therequire_partition_filterandpartition_byoptions must both not be none forrequire_partition_filterto work. This way, non-partitioned tables cannot haverequire_partition_filterapplied to them.This should allow users to just put
require_partition_filterin the dbt_project.yml file instead of needing to make sure they only add it to configs for models that haspartition_byin it.Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.