Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed dbos_class decorators #183

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add missed dbos_class decorators #183

merged 1 commit into from
Jan 22, 2025

Conversation

chuck-dbos
Copy link
Contributor

No description provided.

@chuck-dbos chuck-dbos marked this pull request as ready for review January 22, 2025 20:58
@chuck-dbos chuck-dbos requested a review from qianl15 January 22, 2025 20:59
@chuck-dbos chuck-dbos merged commit 14c7355 into main Jan 22, 2025
10 checks passed
@chuck-dbos chuck-dbos deleted the chuck/use_dbos_class branch January 22, 2025 21:10
Copy link
Member

@kraftp kraftp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused--how did these tests pass?

@chuck-dbos
Copy link
Contributor Author

We say it is required because that's simple. The circumstances in which it is absolutely necessary involve corner cases... you don't need it if the function has no arguments at all, which is true of the Kafka test functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants