Remove RETRIES_EXCEEDED Workflows From Queues Table #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianl15
reviewed
Nov 21, 2024
| regular_handle = queue.enqueue(regular_workflow) | ||
|
|
||
| with pytest.raises(Exception) as exc_info: | ||
| DBOS.recover_pending_workflows() |
There was a problem hiding this comment.
I'm not sure if recover pending workflows should throw an error... It could be solved in a separate PR, but if we throw an error, then no other workflows can be recovered correctly.
There was a problem hiding this comment.
We can resolve this separately
qianl15
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an enqueued workflow enters the dead letter queue (
RETRIES_EXCEEDED), it remains in theworkflow_queuetable forever, potentially blocking the dequeuing of later workflows. This PR removes DLQ'ed workflows from theworkflow_queuetable, unblocking the queue.