Add Ruby 3.2 to CI. Update checkout action versions. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a line to CHANGELOG saying "Added support for Ruby 3.2." Mind fixing the problematic line that Danger is complaining above? Move the content into an UPGRADING.md like https://github.com/slack-ruby/slack-ruby-client/blob/master/UPGRADING.md |
|
@dblock Done. Wasn't originally clear if you wanted CHANGELOG entries for CI updates. Let me know if this needs any further changes. |
dblock
requested changes
Mar 24, 2023
CHANGELOG.md
Outdated
| end | ||
| ``` | ||
| * [#30](https://github.com/dblock/open-weather-ruby-client/pull/30): Added support for Ruby 3.2 | ||
| * [#27](https://github.com/dblock/open-weather-ruby-client/pull/27): Removed default values for Faraday’s SSL settings ca_file and ca_path |
There was a problem hiding this comment.
Needs the name of the contributor please!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs green on my fork.