Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes default values for Faraday’s SSL settings ca_file and ca_path #27

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Removes default values for Faraday’s SSL settings ca_file and ca_path #27

merged 1 commit into from
Mar 21, 2023

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Mar 18, 2023

Closes #26

@dblock
Copy link
Owner

dblock commented Mar 18, 2023

Looks like we need to replace the now defunct Travis-CI with GHA. Care to do it in a separate PR first?

You can probably copy-paste from dblock/iex-ruby-client#117

@sunny sunny mentioned this pull request Mar 20, 2023
Merged
@sunny sunny force-pushed the ssl-ca-defaults branch from 90542b9 to 4451916 Compare March 20, 2023 10:12
@dblock
Copy link
Owner

dblock commented Mar 20, 2023

Rebase now with CI? Thanks!

@sunny sunny force-pushed the ssl-ca-defaults branch from 4451916 to edc10e3 Compare March 20, 2023 17:01
@dblock
Copy link
Owner

dblock commented Mar 20, 2023

Needs a Danger fix, token from here.

@dblock dblock merged commit 7c2fb36 into dblock:master Mar 21, 2023
@sunny sunny deleted the ssl-ca-defaults branch March 21, 2023 09:46
@dblock
Copy link
Owner

dblock commented Mar 25, 2023

I released 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSSL::SSL::SSLError on Heroku
2 participants
@sunny @dblock