Merge configuration options to pass to subschemas #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively merges `Schema.new` options with the provided `Configuration` object (or the default global one) so that subschemas validate using the same configuration as the parent schema. `base_uri` and `meta_schema` are still instance variables because they're modified by keywords (that's why they're `attr_accessor`). `resolve_ref` still passes `ref_resolver` and `regexp_resolver` to subschemas to support caching (because the `CachedResolver` instances are created in `Schema`). They could maybe be cached in `Configuration` instead, but that felt like a bigger change. Fixes: #198
|
This works for me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively merges
Schema.newoptions with the providedConfigurationobject (or the default global one) so that subschemas validate using the same configuration as the parent schema.base_uriandmeta_schemaare still instance variables because they're modified by keywords (that's why they'reattr_accessor).resolve_refstill passesref_resolverandregexp_resolverto subschemas to support caching (because theCachedResolverinstances are created inSchema). They could maybe be cached inConfigurationinstead, but that felt like a bigger change.Fixes: #198