Option to define custom format validators globally

[omkarmoghe]

Was very interested in using the gem, was curious if there was a way to set or "register" formatters globally? Something similar to https://github.com/voxpupuli/json-schema#custom-format-validation. Would you be open to a PR to enable something like this?

[davishmcclurg]

Hi @omkarmoghe! Currently, there isn't a way to register formats globally. You can pass the formats option, but that only applies to a single schema:

json_schemer/README.md

Lines 183 to 190 in da9c8f9

	# custom formats
	formats: {
	'int32' => proc do |instance, _format|
	instance.is_a?(Integer) && instance.bit_length <= 32
	end,
	# disable specific format
	'email' => false
	},

I think it's a great idea, though. I imagine we would want to provide global options for everything (not just formats):

json_schemer/lib/json_schemer/schema.rb

Lines 53 to 69 in da9c8f9

	base_uri: DEFAULT_BASE_URI,
	meta_schema: nil,
	vocabulary: nil,
	format: true,
	formats: DEFAULT_FORMATS,
	content_encodings: DEFAULT_CONTENT_ENCODINGS,
	content_media_types: DEFAULT_CONTENT_MEDIA_TYPES,
	keywords: DEFAULT_KEYWORDS,
	before_property_validation: DEFAULT_BEFORE_PROPERTY_VALIDATION,
	after_property_validation: DEFAULT_AFTER_PROPERTY_VALIDATION,
	insert_property_defaults: false,
	property_default_resolver: DEFAULT_PROPERTY_DEFAULT_RESOLVER,
	ref_resolver: DEFAULT_REF_RESOLVER,
	regexp_resolver: 'ruby',
	output_format: 'classic',
	resolve_enumerators: false,
	access_mode: nil

Would you be open to a PR to enable something like this?

Definitely! Let me know if you want to work on it and I'll do my best help.

[omkarmoghe]

I imagine we would want to provide global options for everything (not just formats)

Agreed! I generally like this approach to making gems configurable: https://dev.to/vinistock/make-a-ruby-gem-configurable-228d

Basically a Configuration singleton object that users can set default options via. Let me know if that approach looks good and I can take a stab at implementing it.

[davishmcclurg]

Basically a Configuration singleton object that users can set default options via. Let me know if that approach looks good and I can take a stab at implementing it.

👍 that sounds good to me.

[davishmcclurg]

@omkarmoghe are you still interested in implementing this?

[omkarmoghe]

Hi @davishmcclurg, apologies for the delay, been a busy month/holiday season. I'm working on implementing this now! Should have a PR up this week 🤞🏽

[omkarmoghe]

Working in this branch: https://github.com/omkarmoghe/json_schemer/tree/default-config

[davishmcclurg]

Thanks again for the help, @omkarmoghe! I merged your changes and will release it shortly.